I've pre ordered the Xs Max, my contract finished anyway! Can't wait

I currently have the iPhone 7. The only phone I'd consider going to personally is the iPhone X. The new phones are the same thing as the normal X expect with more screen room and the A12 chip in it, 95% of the iPhone X is in the iPhone XS. The XR is way overpriced for what it is (looking at specs). This is all my personal opinion.. I'm going to wait until next September because I believe that's when we will be introduced to brand new things and not just an S upgrade. Looking forward to iPhone 11!

Also, iOS 12 comes out on Monday I believe so I'd say wait for that and get it, if you can tolerate your phone with iOS 12 for another year I'd say wait. iOS 12 is supposed to a lot of cool things

I'm thinking about upgrading as well. I like the new phones, but not too, too much has changed.
I think I'm gonna wait it out another year because that's when it's likely more cosmetic changes will be integrated along with better hardware.
Maybe you could do the same.

I would do the upgrade , I'm upgrading myself from my 8 plus !

stick to whatever you like new phones are a shit to get used to

I'll get the most priced one sometime in Dec. I upgrade every year.